Separate components auto update from auto-deps#3165
Separate components auto update from auto-deps#3165gauron99 wants to merge 1 commit intoknative:mainfrom
Conversation
knative-prow
Bot
added
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3165 +/- ##
==========================================
+ Coverage 59.39% 60.14% +0.75%
==========================================
Files 134 134
Lines 13500 13500
==========================================
+ Hits 8018 8120 +102
+ Misses 4539 4408 -131
- Partials 943 972 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
requested review from
lkingland and
matejvasek
and removed request for
jrangelramos and
nainaz
|
/hold might have a better fix |
knative-prow
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow-robot
added
the
needs-rebase
|
I have created a conditional execution of this script so it shouldnt interfere with general PRs. I will monitor in following days/weeks (when we get some deps updates) and see if this works as intended |
|
This seems to work as intended. https://github.com/knative/func/pull/3399/files - at current date this is working as intended - if viewing this at later date, the PR might be rebased |
3 participants
Seeing the annoyance of the verify check in PRs because of this merge of our custom components auto bump and the general knative-wide auto deps bump Im separating these (again).
We have to manually approve (and reopen to run tests) these PRs but it turn it doesn't block any "real PRs" that come in at unfortunate time when some components get bumped.